-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dss
commands exit codes and logging
#90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misohu
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments
misohu
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @NohaIhab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #78
Note: Integration tests in the CI are failing due to microsoft/linux-package-repositories#130, but they can be run locally with
tox -e integration
Summary
Refactors the following
dss
commands:create
initialize
logs
remove
status
stop
With the following changes:
logger.debug
to store the error with traceback1
exit code in failure casesRuntimeError
in failure cases inside the module functionRuntimeError
in main without logging anything else, just by exiting with status code 1 (logging was done in the module function)Exception
in main by providing descriptive error message and use debug to store error and traceback and exit with status code 1.Notice on
dss initialize
This PR refactors
initialize
command in main to catchRuntimeError
even tho it is not currently raised in theinitialize.py
module. This is because we expect to raise this type of error once we refactor the command, refactoring is being tracked in #68.